Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 342 write mpr file #357

Closed
wants to merge 14 commits into from
Closed

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Feb 8, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran the use cases to test that they write output MPR files correctly

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Check out the following branches of METplus, METcalcpy, METplotpy, and METdataio
    feature_1344_stratosphere_bias of METplus
    feature_342_write_mpr_file METcalcpy
    develop branch of METplotpy
    bugfix_247_readnc_no_lon METdataio

Run 1 use cases, s2s/UserScript_fcstGFS_obsERA_StratospherePolar.conf. Verify that that the StratospherePolar use case produces a bunch of MPR files as intermediate output. They will be located in OUTPUT_BASE/UserScript_fcstGFS_obsERA_StratospherePolar/mpr

The documentation should be located at docs/Users_Guide/write_mpr.rst

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    Tests for the script will be added under issue 358

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Please complete this pull request review by [Fill in date].

    02/13/2024

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb linked an issue Feb 8, 2024 that may be closed by this pull request
22 tasks
@CPKalb CPKalb requested a review from bikegeek February 8, 2024 20:36
@CPKalb CPKalb closed this Feb 8, 2024
@CPKalb CPKalb deleted the feature_342_write_mpr_file branch February 8, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the MPR file write script from the Blocking/WR area to the util area
1 participant